[NeMo-UX] Add option to drop optimizer states #11089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashors1 <[email protected]>
ashors1
changed the title
Signed-off-by: ashors1 <[email protected]>
mikolajblaz
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thanks @ashors1 for implementing this.
The bucketing part is correct (some naming comments). I would suggest to implement the optimizer files removal which ensures consistent checkpoint and is checkpoint format specific (impl in MCore) as mentioned in one of the (lengthy) comments. Thanks!
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mikolajblaz
reviewed
Nov 14, 2024
| @@ -498,6 +525,9 @@ def _save_checkpoint(self, trainer: 'pytorch_lightning.Trainer', filepath: str) | |||
| else: | |||
| finalize_fn() | |||
|
|
|||
| if self.save_last_n_optim_states >= 0 and '-last' in filepath: | |||
There was a problem hiding this comment.
I'm wondering (not sure) if this shouldn't be inside the finalize_fn? So called only after current checkpoint was actually finalized
There was a problem hiding this comment.
I think it makes sense to add it to the finalize function so that we always ensure we have at least n checkpoints with optimizer states. I made this change.
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
This reverts commit 868908e.
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
…p-optim-states-async
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
…VIDIA/NeMo into ashors/nemo-ux-drop-optim-states-async
Signed-off-by: ashors1 <[email protected]>
…p-optim-states-async
Signed-off-by: ashors1 <[email protected]>
This reverts commit 5c2deba.
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
Signed-off-by: ashors1 <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
2 similar comments
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information