Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any chance to adopt min_p sampling? #1683

Closed
cyr0930 opened this issue May 28, 2024 · 1 comment
Closed

Any chance to adopt min_p sampling? #1683

cyr0930 opened this issue May 28, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@cyr0930
Copy link

cyr0930 commented May 28, 2024

Some research (I don't think it's thorough tho..) says min_p sampling is better than other sampling strategies.
How about considering adopting min_p in tensorrt-llm project?
@cyr0930 cyr0930 changed the title Any change to adopt min_p sampling? Any chance to adopt min_p sampling? May 28, 2024
@byshiue byshiue mentioned this issue May 29, 2024
Open
@byshiue
Copy link
Collaborator

byshiue commented May 29, 2024

Have a issue to request it #1154. Close this one.

@byshiue byshiue closed this as completed May 29, 2024
@byshiue byshiue added the duplicate This issue or pull request already exists label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@byshiue @cyr0930