Skip to content

rcca: test default kv_cache_reuse option for pytorch multimodal #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

StanleySun639
Copy link
Collaborator

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

RCCA bug#5252057

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@StanleySun639
Copy link
Collaborator Author

/bot run

@StanleySun639 StanleySun639 changed the title rcca: test default kv_cache_reuse option rcca: test default kv_cache_reuse option for pytorch multimodal Jun 27, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10131 [ run ] triggered by Bot

Copy link
Collaborator

@yechank-nvidia yechank-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not supporting kv_cache_reuse for multimodal now.

@StanleySun639
Copy link
Collaborator Author

StanleySun639 commented Jun 27, 2025

We are not supporting kv_cache_reuse for multimodal now.
@yechank-nvidia yes, we need remove the explicit option to test default value, to test this PR: https://github.com/NVIDIA/TensorRT-LLM/pull/4025/files

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10131 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7478 completed with status: 'FAILURE'

@StanleySun639 StanleySun639 force-pushed the user/stsun/rcca-5252057 branch from ea02c60 to cc1c52f Compare June 28, 2025 08:34
@StanleySun639
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10196 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10196 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7528 completed with status: 'FAILURE'

@StanleySun639 StanleySun639 force-pushed the user/stsun/rcca-5252057 branch from cc1c52f to 29f6049 Compare June 30, 2025 01:46
@StanleySun639
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10254 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10254 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7579 completed with status: 'FAILURE'

@StanleySun639 StanleySun639 force-pushed the user/stsun/rcca-5252057 branch from 29f6049 to bd6bb50 Compare June 30, 2025 06:54
@StanleySun639
Copy link
Collaborator Author

/bot run --stage-list "H100_PCIe-TensorRT-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10292 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10292 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7609 (Partly Tested) completed with status: 'FAILURE'

@StanleySun639 StanleySun639 force-pushed the user/stsun/rcca-5252057 branch from bd6bb50 to f084037 Compare July 1, 2025 01:25
@StanleySun639
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10408 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10408 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7696 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@StanleySun639 StanleySun639 merged commit 7135b27 into NVIDIA:main Jul 1, 2025
3 checks passed
@StanleySun639 StanleySun639 deleted the user/stsun/rcca-5252057 branch July 1, 2025 04:12
Shunkangz pushed a commit to Shunkangz/TensorRT-LLM that referenced this pull request Jul 2, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants