Skip to content

Conversation

@moraxu
Copy link
Collaborator

@moraxu moraxu commented Jul 8, 2025

Description

As per NIM request, add a runtime flag to enable fail fast when attn window is too large to fit at least one sequence in KV cache.

Test Coverage

For now, tested with:

trtllm-serve ${ENGINE_PATH} \
    --tokenizer ${CKPT_PATH} \
    --max_seq_len 100 \
    --kv_cache_free_gpu_memory_fraction 0.001 \
    --fail_fast_on_attention_window_too_large

and:

python3 examples/run.py \
--engine_dir ${ENGINE_PATH} \
--max_output_len 100 \
--tokenizer_dir ${CKPT_PATH} \
--input_text "$LONG_INPUT" \
--kv_cache_free_gpu_memory_fraction 0.001 \
--fail_fast_on_attention_window_too_large

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

yiqingy0 and others added 30 commits June 19, 2025 12:58
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
…tral Small multimodal for BS=8 (NVIDIA#5453)

Signed-off-by: Balaram Buddharaju <[email protected]>
…-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=False]` (NVIDIA#5553)

Signed-off-by: Venky <[email protected]>
@moraxu
Copy link
Collaborator Author

moraxu commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11351 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11351 [ run ] completed with state FAILURE
/LLM/release-0.21/L0_MergeRequest_PR pipeline #198 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11355 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11355 [ run ] completed with state FAILURE
/LLM/release-0.21/L0_MergeRequest_PR pipeline #199 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Jul 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11382 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11382 [ run ] completed with state SUCCESS
/LLM/release-0.21/L0_MergeRequest_PR pipeline #203 completed with status: 'FAILURE'

@moraxu moraxu requested review from a team as code owners July 9, 2025 08:38
@moraxu moraxu requested a review from lucaslie July 9, 2025 08:38
@moraxu
Copy link
Collaborator Author

moraxu commented Jul 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11415 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11415 [ run ] completed with state FAILURE
/LLM/release-0.21/L0_MergeRequest_PR pipeline #206 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Jul 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11454 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11454 [ run ] completed with state FAILURE
/LLM/release-0.21/L0_MergeRequest_PR pipeline #211 completed with status: 'FAILURE'

@moraxu
Copy link
Collaborator Author

moraxu commented Jul 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11467 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11467 [ run ] completed with state ABORTED

@moraxu
Copy link
Collaborator Author

moraxu commented Jul 10, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11476 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11476 [ run ] completed with state SUCCESS
/LLM/release-0.21/L0_MergeRequest_PR pipeline #213 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Copy link
Collaborator

@MartinMarciniszyn MartinMarciniszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moraxu , we are not adding any new features to release/0.21. That branch has reached FC date three weeks ago. Please target main.

Signed-off-by: moraxu <[email protected]>
@moraxu moraxu force-pushed the dev-mguzek-enable-fail-fast-when-attention-window-too-large branch from 5b1d80c to c5ec75e Compare July 11, 2025 20:23
@moraxu moraxu changed the base branch from release/0.21 to main July 11, 2025 20:23
@moraxu moraxu closed this Jul 11, 2025
@moraxu
Copy link
Collaborator Author

moraxu commented Jul 11, 2025

Reopened in #5817 due to rebase issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.