-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Feature] Add a runtime flag to enable fail fast when attn window is too large to fit at least one sequence in KV cache #5817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yiqing Yan <[email protected]>
…est name in perf test (NVIDIA#5357) Signed-off-by: ruodil <[email protected]>
NVIDIA#5363) Signed-off-by: qqiao <[email protected]>
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
Signed-off-by: Yi Zhang <[email protected]>
…-pick NVIDIA#5231) (NVIDIA#5378) Signed-off-by: Kaiyu Xie <[email protected]>
Signed-off-by: Ivy Zhang <[email protected]>
…tral Small multimodal for BS=8 (NVIDIA#5453) Signed-off-by: Balaram Buddharaju <[email protected]>
Signed-off-by: Wanli Jiang <[email protected]>
…IA#5461) Signed-off-by: ruodil <[email protected]> Co-authored-by: Larry <[email protected]>
Signed-off-by: Hui Gao <[email protected]>
Signed-off-by: qqiao <[email protected]>
…#5373) Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
Signed-off-by: Superjomn <[email protected]>
Signed-off-by: Anurag Mukkara <[email protected]>
Signed-off-by: ixlmar <[email protected]>
Signed-off-by: Kaiyu Xie <[email protected]>
Signed-off-by: ixlmar <[email protected]>
Signed-off-by: qqiao <[email protected]>
Signed-off-by: Superjomn <[email protected]>
…tions (NVIDIA#5490) Signed-off-by: ixlmar <[email protected]>
…-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=False]` (NVIDIA#5553) Signed-off-by: Venky <[email protected]>
Signed-off-by: qqiao <[email protected]>
Signed-off-by: Superjomn <[email protected]>
Signed-off-by: nv-guomingz <[email protected]>
) Signed-off-by: zhengd-nv <[email protected]>
…A#5397) Signed-off-by: Yi Zhang <[email protected]>
) Signed-off-by: Kaiyu Xie <[email protected]>
…VIDIA#5602) Signed-off-by: bhsueh <[email protected]>
…lculation. (NVIDIA#5625) Signed-off-by: Frank Di Natale <[email protected]>
|
/bot run |
|
PR_Github #11351 [ run ] triggered by Bot |
|
PR_Github #11351 [ run ] completed with state |
|
/bot run |
|
PR_Github #11355 [ run ] triggered by Bot |
|
PR_Github #11355 [ run ] completed with state |
|
/bot run |
|
PR_Github #11382 [ run ] triggered by Bot |
|
PR_Github #11382 [ run ] completed with state |
|
/bot run |
|
PR_Github #11415 [ run ] triggered by Bot |
|
PR_Github #11415 [ run ] completed with state |
|
/bot run |
|
PR_Github #11454 [ run ] triggered by Bot |
|
PR_Github #11454 [ run ] completed with state |
|
/bot run |
|
PR_Github #11467 [ run ] triggered by Bot |
|
PR_Github #11467 [ run ] completed with state |
|
/bot run |
|
PR_Github #11476 [ run ] triggered by Bot |
|
PR_Github #11476 [ run ] completed with state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moraxu , we are not adding any new features to release/0.21. That branch has reached FC date three weeks ago. Please target main.
Signed-off-by: moraxu <[email protected]>
5b1d80c to
c5ec75e
Compare
|
Reopened in #5817 due to rebase issues |
Description
As per NIM request, add a runtime flag to enable fail fast when attn window is too large to fit at least one sequence in KV cache.
Test Coverage
For now, tested with:
and:
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.