Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Nov 7, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Updated test skip configurations to include additional test scenarios across multiple categories.

@jieli-matrix jieli-matrix marked this pull request as ready for review November 10, 2025 05:54
@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

Added multiple SKIP entries to the test waiver list for failing tests spanning phi, multimodal, nemotron, QwQ, and Llama variants, each mapped to corresponding NV bug references. No deletions or functional changes; purely extends the set of skipped tests.

Changes

Cohort / File(s) Change Summary
Test Waivers
tests/integration/test_lists/waives.txt
Added multiple SKIP entries for failing integration tests across various model types and serving configurations with associated bug references

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • This is a straightforward data file update with no logic or structural changes; review primarily involves verifying the new skip entries are properly formatted and bug references are valid.

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description 'waive failed cases.' is incomplete and lacks required sections from the template, including explanation of the issue/solution, test coverage details, and the PR checklist confirmation. Provide a complete description following the template: explain which tests/issues are being waived and why, detail test coverage, and check all PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Add failed cases into waives.txt' clearly and specifically summarizes the main change: adding failed test cases to the waives.txt file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a7033a9 and 3f6a6be.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-29T14:07:45.863Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/waives.txt
📚 Learning: 2025-08-06T13:58:07.506Z
Learnt from: galagam
Repo: NVIDIA/TensorRT-LLM PR: 6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/waives.txt (1)

415-416: Possible duplicate waives for the same test with different bug references.

Lines 415–416 and lines 423–424 both waive accuracy/test_disaggregated_serving.py::TestGPTOSS::test_auto_dtype with different bug references:

  • Lines 415–416: Bug 5644632
  • Lines 423–424: Bug 5643652

Verify whether both waive entries are intentional (e.g., addressing separate issues) or if one is a merge conflict artifact that should be removed.

Also applies to: 423-424

@jieli-matrix jieli-matrix enabled auto-merge (squash) November 10, 2025 06:01
@jieli-matrix jieli-matrix self-assigned this Nov 10, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23966 [ run ] triggered by Bot. Commit: 96c47bc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23966 [ run ] completed with state FAILURE. Commit: 96c47bc
/LLM/main/L0_MergeRequest_PR pipeline #18050 (Partly Tested) completed with status: 'FAILURE'

@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23978 [ run ] triggered by Bot. Commit: 96c47bc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23978 [ run ] completed with state FAILURE. Commit: 96c47bc
/LLM/main/L0_MergeRequest_PR pipeline #18055 (Partly Tested) completed with status: 'FAILURE'

@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23985 [ run ] triggered by Bot. Commit: 96c47bc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23985 [ run ] completed with state FAILURE. Commit: 96c47bc
/LLM/main/L0_MergeRequest_PR pipeline #18063 (Partly Tested) completed with status: 'FAILURE'

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20251107_LLM_FUNCTION_NIM_TEST_23 branch from 96c47bc to 7916817 Compare November 10, 2025 09:08
@jieli-matrix jieli-matrix requested review from a team as code owners November 10, 2025 09:08
@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24005 [ run ] triggered by Bot. Commit: 7916817

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24005 [ run ] completed with state SUCCESS. Commit: 7916817
/LLM/main/L0_MergeRequest_PR pipeline #18082 (Partly Tested) completed with status: 'SUCCESS'

@jieli-matrix jieli-matrix force-pushed the user/qa/post_update_waive_20251107_LLM_FUNCTION_NIM_TEST_23 branch from 7916817 to 9b687ad Compare November 11, 2025 02:20
@jieli-matrix
Copy link
Collaborator

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24082 [ run ] triggered by Bot. Commit: 9b687ad

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251107_LLM_FUNCTION_NIM_TEST_23 branch from 9b687ad to 5dba873 Compare November 11, 2025 02:57
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24082 [ run ] completed with state SUCCESS. Commit: 9b687ad
/LLM/main/L0_MergeRequest_PR pipeline #18148 (Partly Tested) completed with status: 'FAILURE'

@jieli-matrix
Copy link
Collaborator

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24103 [ reuse-pipeline ] triggered by Bot. Commit: 5dba873

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24103 [ reuse-pipeline ] completed with state SUCCESS. Commit: 5dba873
Can't reuse PR_Github #24082 (Partly Tested) with status: FAILED

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20251107_LLM_FUNCTION_NIM_TEST_23 branch from 5dba873 to 96dcecb Compare November 11, 2025 04:34
@LarryXFly LarryXFly disabled auto-merge November 11, 2025 04:40
@LarryXFly LarryXFly merged commit fac5220 into NVIDIA:main Nov 11, 2025
4 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20251107_LLM_FUNCTION_NIM_TEST_23 branch November 11, 2025 07:13
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants