Skip to content

Conversation

@bobboli
Copy link
Collaborator

@bobboli bobboli commented Nov 7, 2025

Summary by CodeRabbit

  • Tests
    • Updated test skip configuration to target a specific test case rather than a directory-level skip, enabling more granular control over test exclusions.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Bo Li <[email protected]>
@bobboli
Copy link
Collaborator Author

bobboli commented Nov 7, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

📝 Walkthrough

Walkthrough

The change updates the waived tests list by replacing a broad directory-level test path selector with a specific test case path, narrowing the scope of a test skip from an entire directory to a single test function.

Changes

Cohort / File(s) Change Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Replaced generic path selector unittest/_torch/modules with specific test case unittest/_torch/modules/test_mla_helix.py::test_mla_helix_distributed in the waived tests list

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty and contains only the template placeholder text without any actual content explaining the changes or rationale. Complete the Description and Test Coverage sections with clear explanations of what changed and why. Provide specific details about the test file modifications and their purpose.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title directly references the NVBugs ticket and clearly summarizes the change: updating the unwaive list for a specific bug fix.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23828 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23828 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #17939 completed with status: 'FAILURE'

@bobboli
Copy link
Collaborator Author

bobboli commented Nov 7, 2025

/bot run

@bobboli bobboli requested review from dc3671 and liji-nv November 7, 2025 14:45
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23854 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23854 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #17959 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@bobboli bobboli changed the title [https://nvbugs/5633340][fix] Update unwaive list. [https://nvbugs/5637037][fix] Update unwaive list. Nov 8, 2025
@dc3671 dc3671 self-requested a review November 8, 2025 10:20
@dc3671
Copy link
Collaborator

dc3671 commented Nov 8, 2025

/bot run --post-merge

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23893 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23893 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #17988 completed with status: 'FAILURE'

@bobboli
Copy link
Collaborator Author

bobboli commented Nov 9, 2025

/bot run --post-merge --reuse-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23913 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23913 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #18003 completed with status: 'FAILURE'

@bobboli
Copy link
Collaborator Author

bobboli commented Nov 9, 2025

/bot run --post-merge --reuse-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23915 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23915 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #18005 completed with status: 'FAILURE'

@bobboli
Copy link
Collaborator Author

bobboli commented Nov 9, 2025

/bot run --post-merge --reuse-test

1 similar comment
@bobboli
Copy link
Collaborator Author

bobboli commented Nov 9, 2025

/bot run --post-merge --reuse-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23918 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23918 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #18007 completed with status: 'FAILURE'

@bobboli
Copy link
Collaborator Author

bobboli commented Nov 9, 2025

/bot run --post-merge --reuse-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23926 [ run ] triggered by Bot. Commit: ea58704

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23926 [ run ] completed with state SUCCESS. Commit: ea58704
/LLM/main/L0_MergeRequest_PR pipeline #18015 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@QiJune QiJune merged commit 67af7c1 into NVIDIA:main Nov 10, 2025
8 of 11 checks passed
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants