Jax example cleanup and replace pjit with jit. #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouiz
force-pushed
the
jax_example_cleanup
branch
from
c93cc8c
to
be24bb6
Compare
phu0ngng
approved these changes
Aug 19, 2024
|
/te-ci jax |
Signed-off-by: Frederic Bastien <[email protected]>
/opt/transformer-engine/examples/jax/encoder/test_multigpu_encoder.py:214: DeprecationWarning: jax.tree_map is deprecated: u se jax.tree.map (jax v0.4.25 or newer) or jax.tree_util.tree_map (any JAX version). params_axes_sharding = jax.tree_map(to_device_axis, nn_partitioning.get_axis_names(params_axes)) Signed-off-by: Frederic Bastien <[email protected]>
Signed-off-by: Frederic Bastien <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Frederic Bastien <[email protected]>
nouiz
force-pushed
the
jax_example_cleanup
branch
from
82e4f5f
to
8368d29
Compare
|
/te-ci jax |
Signed-off-by: Frederic Bastien <[email protected]>
nouiz
force-pushed
the
jax_example_cleanup
branch
from
9a27195
to
88642ca
Compare
|
/te-ci jax |
Signed-off-by: Frederic Bastien <[email protected]>
nouiz
force-pushed
the
jax_example_cleanup
branch
from
4ae4257
to
0dc3179
Compare
for more information, see https://pre-commit.ci
|
/te-ci jax |
BeingGod
pushed a commit
to BeingGod/TransformerEngine
that referenced
this pull request
Aug 30, 2024
* Use jit instead of pjit --------- Signed-off-by: Frederic Bastien <[email protected]> Co-authored-by: Phuong Nguyen <[email protected]> Signed-off-by: beinggod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
I did the minimal conversion. Maybe some refactoring would simplify it further.
Checklist: