Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for building wheels #1148

Merged
merged 14 commits into from
Sep 3, 2024
Merged

Improvements for building wheels #1148

merged 14 commits into from
Sep 3, 2024

Conversation

ksivaman
Copy link
Member

Description

Make build time improvements and bug fixes for publishing wheels.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ksivaman
Improvements for wheels
92d1715 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
fix
edaa629 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
Merge branch 'main' into wheel_build_improvements
adbbd40
@ksivaman
Fixes for wheel build
83c05e1 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
Move package finder to common
94ec228 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
format
665fa39 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
Fixes
c4c5707 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
Lint
a38556a 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
fix
d1ec443 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
FIx
9399ca5 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman ksivaman added build Build system 1.10.0 labels Aug 29, 2024
@ksivaman ksivaman self-assigned this Aug 29, 2024
@ksivaman
Copy link
Member Author

/te-ci

timmoon10
timmoon10 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member Author

/te-ci

@ksivaman
fix paddle ci
1357637 
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
@ksivaman
Copy link
Member Author

ksivaman commented Sep 3, 2024

/te-ci paddle

@ksivaman
Copy link
Member Author

ksivaman commented Sep 3, 2024

Pipelines 18092621 and 17985240

@ksivaman ksivaman merged commit 93f00a7 into NVIDIA:main Sep 3, 2024
14 of 15 checks passed
ksivaman added a commit that referenced this pull request Sep 3, 2024
@ksivaman
Improvements for building wheels (#1148)
a7e9d3e 
* Improvements for wheels

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* fix

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* Fixes for wheel build

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* Move package finder to common

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* format

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* Fixes

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* Lint

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* fix

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* FIx

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* Fix CI and distributed test

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* fix

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

* fix paddle ci

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>

---------

Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmoon10 timmoon10 timmoon10 approved these changes

Assignees

@ksivaman ksivaman

Labels
1.10.0 build Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksivaman @timmoon10