Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Fix wgrads for GroupedLinear when weights don't require grad #1258

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[PyTorch] Fix wgrads for GroupedLinear when weights don't require grad #1258

merged 2 commits into from
Oct 17, 2024

Conversation

yaox12
Copy link
Collaborator

@yaox12 yaox12 commented Oct 16, 2024

Description

Fix wgrads for GroupedLinear when weights don't require grad.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@yaox12 yaox12 requested a review from timmoon10 October 16, 2024 03:35
@yaox12
Copy link
Collaborator Author

yaox12 commented Oct 16, 2024

/te-ci pytorch

ksivaman
ksivaman approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM

@ksivaman
Copy link
Member

/te-ci pytorch

@yaox12
Copy link
Collaborator Author

yaox12 commented Oct 17, 2024

Merge this as the CI passes except for a doc test failing with irrelevant error.

@yaox12 yaox12 merged commit 2d7020e into NVIDIA:main Oct 17, 2024
26 of 27 checks passed
@yaox12 yaox12 deleted the xiny/fix_wgrad branch October 17, 2024 13:20
ksivaman added a commit that referenced this pull request Oct 30, 2024
@yaox12 @ksivaman
[PyTorch] Fix wgrads for GroupedLinear when weights don't require grad (
a399997 
#1258)

Fix wgrad for GroupedLinear when weights doesn't require grad

Signed-off-by: Xin Yao <[email protected]>
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
timmoon10 pushed a commit to timmoon10/TransformerEngine that referenced this pull request Nov 7, 2024
@yaox12 @ksivaman
[PyTorch] Fix wgrads for GroupedLinear when weights don't require grad (
6fe15ff 
NVIDIA#1258)

Fix wgrad for GroupedLinear when weights doesn't require grad

Signed-off-by: Xin Yao <[email protected]>
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksivaman ksivaman ksivaman approved these changes

@timmoon10 timmoon10 Awaiting requested review from timmoon10

Assignees
No one assigned
Labels
1.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaox12 @ksivaman