-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAX] Skip V100 encoder tests #1262
Merged
phu0ngng
merged 6 commits into
NVIDIA:main
from
zlsh80826:rewang/skip-v100-encoder-tests
Oct 22, 2024
Merged
[JAX] Skip V100 encoder tests #1262
phu0ngng
merged 6 commits into
NVIDIA:main
from
zlsh80826:rewang/skip-v100-encoder-tests
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlsh80826
force-pushed
the
rewang/skip-v100-encoder-tests
branch
from
October 16, 2024 12:42
bd49e48
to
cf04939
Compare
/te-ci jax |
ksivaman
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/te-ci jax |
phu0ngng
approved these changes
Oct 16, 2024
/te-ci jax |
Signed-off-by: Reese Wang <[email protected]>
Signed-off-by: Reese Wang <[email protected]>
Signed-off-by: Reese Wang <[email protected]>
zlsh80826
force-pushed
the
rewang/skip-v100-encoder-tests
branch
from
October 20, 2024 06:37
d39a122
to
4de8d6f
Compare
/te-ci jax |
Signed-off-by: Reese Wang <[email protected]>
/te-ci jax |
Signed-off-by: Reese Wang <[email protected]>
/te-ci jax |
timmoon10
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Skip encoder tests on V100 * Fix mulitprocessing jax.distributed.init * Remove XLA xla_gpu_deterministic_ops which causes segfault --------- Signed-off-by: Reese Wang <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V100 doesn't have BF16 hardware support, this PR is to skip the V100 failing tests with BF16 data type.
Fixes # (issue)
Type of change
Changes
Skip all encoder tests if the CC < 80
I have read and followed the contributing guidelines
The functionality is complete
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes