Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version constraint of flash-attn needs to be updated #689

Closed
lucifer1004 opened this issue Feb 29, 2024 · 3 comments
Closed

Version constraint of flash-attn needs to be updated #689

lucifer1004 opened this issue Feb 29, 2024 · 3 comments
Assignees

Comments

@lucifer1004
Copy link

Version: latest stable

Currently, the version constraint for flash-attn is:

add_unique(install_reqs, ["torch", "flash-attn>=2.0.6,<=2.4.2,!=2.0.9,!=2.1.0"])

So most likely v2.4.2 is going to be installed. However, this version seems to have some issues when imported, claiming some missing symbols. I uninstalled it and manually installed the latest v2.5.5, and the import succeeded.

The question is: why do we set this upper bound for flash-attn?

@timmoon10
Copy link
Collaborator

timmoon10 commented Feb 29, 2024

Flash Attention is being rapidly developed and its API is somewhat unstable. We've found it safer to only bump the version constraint after validating that Flash Attention works as expected. We are open to improving our workflows though.

Related: #519

Pinging @cyanguwa.

@ptrendx
Copy link
Member

ptrendx commented May 16, 2024

We updated flash attention version to 2.5.8 (current latest).

@ptrendx ptrendx closed this as completed May 16, 2024
@ianporada
Copy link

ianporada commented Aug 30, 2024

Is it possible to look into updating max to flash-attn version v2.6.3? The compile time of this version is much faster for me than the current max v2.5.8.

Edit: Never mind, realized I was looking at stable branch and main is updated to 2.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants