Skip to content

Conversation

@viralbhadeshiya
Copy link
Contributor

Description

closes #5022

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Nov 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@viralbhadeshiya
Copy link
Contributor Author

@bernhardmgruber this is final PR for nested_namespace fixes, This will finish all nested namespaces related changes.

@fbusato
Copy link
Contributor

fbusato commented Nov 3, 2025

/ok to test fc24887

Copy link
Contributor

@fbusato fbusato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good. A leave the final word to Bernhard

@github-actions

This comment has been minimized.

@viralbhadeshiya
Copy link
Contributor Author

Apologies, It's look like I made some mistake, I'll fix it tomorrow. you guys can put hold on this till then. Thanks for understanding.

@bernhardmgruber
Copy link
Contributor

/ok to test cb28e3d

@github-actions

This comment has been minimized.

@bernhardmgruber bernhardmgruber enabled auto-merge (squash) November 4, 2025 12:10
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🥳 CI Workflow Results

🟩 Finished in 3h 50m: Pass: 100%/133 | Total: 3d 16h | Max: 3h 06m | Hits: 47%/309743

See results here.

@bernhardmgruber bernhardmgruber merged commit e6ad507 into NVIDIA:main Nov 4, 2025
287 of 290 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 4, 2025
@bernhardmgruber
Copy link
Contributor

@viralbhadeshiya thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rewrite all C++ files to use nested namespace definitions

3 participants