From a2926f1e40267d23c82cdeb710f1aa4c65e2bf87 Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Mon, 26 Aug 2024 10:58:43 +0200 Subject: [PATCH 1/3] [no-relnote] Fix typo in log collection tooling Signed-off-by: Evan Lezar --- tests/e2e/gpu-feature-discovery_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/gpu-feature-discovery_test.go b/tests/e2e/gpu-feature-discovery_test.go index 998ef244b..713608a17 100644 --- a/tests/e2e/gpu-feature-discovery_test.go +++ b/tests/e2e/gpu-feature-discovery_test.go @@ -67,7 +67,7 @@ var _ = NVDescribe("GPU Feature Discovery", func() { "nodes", "namespaces", "deployments", - "demonsets", + "daemonsets", "nodeFeature", } From 2a78ebe05adc463d366caa900867043aece109e4 Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Mon, 26 Aug 2024 11:05:49 +0200 Subject: [PATCH 2/3] [no-relnote] Use ubi8 image in tests With https://github.com/NVIDIA/k8s-device-plugin/pull/884 we removed the ubuntu22.04 images. This change uses the ubi8 images since these are now the only images. Signed-off-by: Evan Lezar --- .github/workflows/staging_e2e.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/staging_e2e.yaml b/.github/workflows/staging_e2e.yaml index 8b6d30e55..5978561ab 100644 --- a/.github/workflows/staging_e2e.yaml +++ b/.github/workflows/staging_e2e.yaml @@ -60,7 +60,7 @@ jobs: env: KUBECONFIG: ${{ github.workspace }}/kubeconfig E2E_IMAGE_REPO: ghcr.io/nvidia/k8s-device-plugin - E2E_IMAGE_TAG: ${COMMIT_SHORT_SHA}-ubuntu22.04 + E2E_IMAGE_TAG: ${COMMIT_SHORT_SHA}-ubi8 LOG_ARTIFACTS: ${{ github.workspace }}/e2e_logs run: | make test-e2e @@ -84,5 +84,5 @@ jobs: channel-id: ${{ secrets.SLACK_CHANNEL_ID }} slack-message: | :red_target: On repository ${{ github.repository }} the Workflow *${{ github.workflow }}* has failed. - + Details: ${{ env.SUMMARY_URL }} From 8b5306b59e87943db48bee401900c7244203a4bd Mon Sep 17 00:00:00 2001 From: Evan Lezar Date: Mon, 26 Aug 2024 14:06:36 +0200 Subject: [PATCH 3/3] [no-relnote] Don't use animated emoji for slack notification Signed-off-by: Evan Lezar --- .github/workflows/e2e.yaml | 4 ++-- .github/workflows/staging_e2e.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index c711d8d20..4e563ebe2 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -48,7 +48,7 @@ jobs: env: KUBECONFIG: ${{ github.workspace }}/kubeconfig E2E_IMAGE_REPO: ghcr.io/nvidia/k8s-device-plugin - E2E_IMAGE_TAG: ${COMMIT_SHORT_SHA}-ubuntu22.04 + E2E_IMAGE_TAG: ${COMMIT_SHORT_SHA}-ubi8 LOG_ARTIFACTS: ${{ github.workspace }}/e2e_logs run: | make test-e2e @@ -71,6 +71,6 @@ jobs: with: channel-id: ${{ secrets.SLACK_CHANNEL_ID }} slack-message: | - :red_target: On repository ${{ github.repository }} the Workflow *${{ github.workflow }}* has failed. + :x: On repository ${{ github.repository }} the Workflow *${{ github.workflow }}* has failed. Details: ${{ env.SUMMARY_URL }} diff --git a/.github/workflows/staging_e2e.yaml b/.github/workflows/staging_e2e.yaml index 5978561ab..8f10c1073 100644 --- a/.github/workflows/staging_e2e.yaml +++ b/.github/workflows/staging_e2e.yaml @@ -83,6 +83,6 @@ jobs: with: channel-id: ${{ secrets.SLACK_CHANNEL_ID }} slack-message: | - :red_target: On repository ${{ github.repository }} the Workflow *${{ github.workflow }}* has failed. + :x: On repository ${{ github.repository }} the Workflow *${{ github.workflow }}* has failed. Details: ${{ env.SUMMARY_URL }}