Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NVIDIA_CDI_HOOK_PATH instead of NVIDIA_CTK_PATH #210

Open
elezar opened this issue Nov 28, 2024 · 0 comments · May be fixed by #212
Open

Use NVIDIA_CDI_HOOK_PATH instead of NVIDIA_CTK_PATH #210

elezar opened this issue Nov 28, 2024 · 0 comments · May be fixed by #212
Assignees
@elezar

Comments

@elezar
Copy link
Member

elezar commented Nov 28, 2024

Instead of relying on the nvidia-ctk binary as the hook implementation, we should move to using nvidia-cdi-hook. This only implements the required CDI hooks.

We would need to:

  • Use the NVIDIA_CDI_HOOK_PATH envvar
  • Rename / replace the helm option
  • Rename local references

Note that we already use WithNVIDIACDIHookPath when instantiating the nvcdi library instance:

k8s-dra-driver/cmd/nvidia-dra-plugin/cdi.go

Line 106 in 32805fe

nvcdi.WithNVIDIACDIHookPath(h.nvidiaCTKPath),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elezar elezar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NVIDIA_CDI_HOOK_PATH instead of NVIDIA_CTK_PATH lengrongfu/k8s-dra-driver
1 participant
@elezar