-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: initial change to add nemo data store CRD in nim operator #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slu2011
requested review from
ArangoGutierrez,
shivamerla and
visheshtanksale
as code owners
November 18, 2024 23:57
shivamerla
reviewed
Nov 19, 2024
shivamerla
reviewed
Nov 19, 2024
shivamerla
reviewed
Nov 19, 2024
slu2011
force-pushed
the
ds
branch
5 times, most recently
from
November 25, 2024 18:49
3ed26de
to
f904dda
Compare
Looks great! thanks @slu2011 |
shivamerla
previously approved these changes
Nov 26, 2024
shivamerla
approved these changes
Nov 26, 2024
Signed-off-by: shil <[email protected]>
Signed-off-by: shil <[email protected]>
Signed-off-by: shil <[email protected]>
…fest Signed-off-by: shil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shil [email protected]
First change to add CRD for nemo data store. Controller is not hooked up yet.