Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Improve milvus connection logging #173

Open
edknv opened this issue Oct 16, 2024 · 0 comments
Open

[FEA]: Improve milvus connection logging #173

edknv opened this issue Oct 16, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@edknv
Copy link
Collaborator

edknv commented Oct 16, 2024

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Would be nice

Please provide a clear description of problem this feature solves

Even when the nv-ingest container is successfully launched, the log shows

nv-ingest-ms-runtime-1  | 2024-10-16 19:37:12,116 - ERROR - Failed to create new connection using: ece0745f72fd43e1ba331491b9b71eb8
nv-ingest-ms-runtime-1  | 2024-10-16 19:37:12,116 - ERROR - Failed to connect to milvus: <MilvusException: (code=2, message=Fail connecting to server on milvus:19530. Timeout)>

Describe the feature, and optionally a solution or implementation and any alternatives

It says ERROR but it is intended behavior (when there is no milvus service running, it is simply logged and the pipeline is built successfully). We should imporve logging so it's not confusing to the user.

Additional context

No response

@edknv edknv added the feature request New feature or request label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant