Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile converter should have best effort mode to deal with corrupted/incomplete profiles #2174

Open
jlowe opened this issue Jun 26, 2024 · 0 comments

Comments

@jlowe
Copy link
Member

jlowe commented Jun 26, 2024

Is your feature request related to a problem? Please describe.
Sometimes profiles generated by the self-profiler are incomplete due to a violent shutdown of the executor. This leaves the compressed profile in a truncated state that cannot be decompressed successfully, and thus no profile data can be collected.

Describe the solution you'd like
The profile converter should deal with compressed files directly, setting up a decompression stream and reading records from that stream. There should be a flag that can be passed that will read all of the complete records that it can before it encounters a decompression error and then work with the profile it has thus far to salvage what it can from the incomplete file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants