Improve from_json_to_raw_map
#2562
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
revans2
previously approved these changes
Nov 5, 2024
| std::unique_ptr<cudf::column> const& extracted_keys, | ||
| std::unique_ptr<cudf::column> const& extracted_values, | ||
| rmm::cuda_stream_view stream) | ||
| { | ||
| auto const keys_child = extracted_keys->child(cudf::strings_column_view::chars_column_index); | ||
| if (extracted_keys->size() == 0) { | ||
| std::cerr << "Extract keys-values are all empty.\n" << std::endl; |
There was a problem hiding this comment.
I think we need to delete this.
There was a problem hiding this comment.
This is debug code to help me figure out what's going on with the intermediate results. It will not be compiled into production.
# Conflicts: # src/main/cpp/src/json_utils.hpp
Signed-off-by: Nghia Truong <[email protected]>
|
build |
This was
linked to
issues
Nov 5, 2024
|
Need to add more integration tests to spark-rapids to verify before merging this. |
Signed-off-by: Nghia Truong <[email protected]>
This reverts commit 22040d3.
Signed-off-by: Nghia Truong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of missing functionalities to
from_json_to_raw_map, which is the backend offrom_jsonwithmap<string, string>schema:Depends on:
concat_json#2557Closes:
from_jsonto Map type should produce null for invalid entries spark-rapids#9592from_json_to_raw_mapdoes not support single quotes #2563RECOVER_WITH_NULLwhen parsing JSON infrom_json_to_raw_map#2553