Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] from_json does not support input with \n in it. #10489

Closed
revans2 opened this issue Feb 23, 2024 · 2 comments
Closed

[BUG] from_json does not support input with \n in it. #10489

revans2 opened this issue Feb 23, 2024 · 2 comments
Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf

Comments

@revans2
Copy link
Collaborator

revans2 commented Feb 23, 2024

Describe the bug
Because of how from_json works we don't have a way to support \n in the JSON input itself. I don't think this is likely to happen and we throw an exception if we run into it. But there is a Spark unit test that actually tries to do this, so we probably should figure out how to support it eventually.

@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 23, 2024
@revans2 revans2 mentioned this issue Feb 26, 2024
62 tasks
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Feb 27, 2024
@revans2
Copy link
Collaborator Author

revans2 commented Mar 14, 2024

Actually after looking at more real world data it is clear that this does happen, and we need to support it. I filed rapidsai/cudf#15277 in CUDF to help us address this.

@revans2 revans2 added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Mar 14, 2024
@revans2
Copy link
Collaborator Author

revans2 commented Oct 18, 2024

This was fixed by #11549

@revans2 revans2 closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf
Projects
None yet
Development

No branches or pull requests

2 participants