Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] support unspill for RapidsHostColumnarBatch #9107

Closed
abellina opened this issue Aug 24, 2023 · 2 comments
Closed

[FEA] support unspill for RapidsHostColumnarBatch #9107

abellina opened this issue Aug 24, 2023 · 2 comments
Labels
feature request New feature or request performance A performance related task/issue reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@abellina
Copy link
Collaborator

"unspill" is a feature we have off by default #7671. Once we have dusted the cobwebs and made sure it's working properly, we should also support unspilling RapidsHostColumnarBatch. This may be really easy if we already finished #9105, because it would come for free (it's just a memcpy).

This is here so we don't loose track of this missing feature.
@abellina abellina added feature request New feature or request ? - Needs Triage Need team to review and classify performance A performance related task/issue reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Aug 24, 2023
@abellina abellina mentioned this issue Aug 24, 2023
Merged
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Aug 30, 2023
@abellina abellina mentioned this issue Aug 30, 2023
Open
35 tasks
@binmahone
Copy link
Collaborator

Hi @abellina , I'm seeing this issue from the todo list of #8874. I assume this issue should be closed since RapidsHostColumnarBatch no longer exists. I have just opened another issue #12184 for my own purposes, not sure if it will fix what wanted to fix. Please take a look.

@abellina
Copy link
Collaborator Author

Yeah, it's good to close this issue, we can go with yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request performance A performance related task/issue reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abellina @mattahrens @binmahone