Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write numRecords in CDC files regardless of whether we are using deletion vectors [databricks] #12196

Merged

Conversation

razajafri
Copy link
Collaborator

This PR sets the keepNumRecords boolean to true when querying candidate files in a change so we always write numRecords stats on Databricks 14.3

fixes #12047

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@sameerz
Copy link
Collaborator

sameerz commented Feb 24, 2025

build

@sameerz
Copy link
Collaborator

sameerz commented Feb 24, 2025

@razajafri this PR needs a signoff.

Signed-off-by: Raza Jafri <[email protected]>
@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri merged commit 6fa0abf into NVIDIA:branch-25.04 Feb 25, 2025
51 of 52 checks passed
@razajafri razajafri deleted the SP-10661-db-14.3-delta-lake-support branch February 25, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [DB 14.3] numRecords stat in Delta Lake tables is not set on GPU
3 participants