Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative paths in __init__.py #32

Open
ryanmrichard opened this issue Aug 18, 2022 · 1 comment
Open

Use relative paths in __init__.py #32

ryanmrichard opened this issue Aug 18, 2022 · 1 comment

Comments

@ryanmrichard
Copy link
Member

Right now the __init__.py files generated by the CMake API use absolute paths for the headers and libraries which are set to the build directory. For installation purposes, these paths should be relative to an installation root (said root is usually a staging directory while building, and the actual installation root after install).

Off the top of my head I'm not sure where Python bindings are usually installed in a typical GNU build (lib maybe?), but I'm sure there's a precedent.

Since CMaize currently does not support installation, this is not a high-priority issue.

@wadejong
Copy link

This should be something we can simplify. But, this means we need to agree what the install looks like. We can install Python packages in the same location as the headers and binaries, and require PYTHONPATH to be set. If you want the python packages in the normal python location, we need to make sure both are synchronized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants