Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Excalidraw Design #41

Open
ryanmrichard opened this issue Feb 3, 2022 · 0 comments
Open

Update Excalidraw Design #41

ryanmrichard opened this issue Feb 3, 2022 · 0 comments

Comments

@ryanmrichard
Copy link
Member

ryanmrichard commented Feb 3, 2022

As code is written the design may need tweaked. This issue tracks the changes that need to happen to the Excalidraw document. It's probably easier to just make all these changes at once.

  • Move Buffer::reallocate to Allocator
    • Allocation makes buffers, attempting to reallocate in the buffer leads to weird scenarios where you ask a TABuffer to reallocate itself as say a TAMM buffer. Thus I think reallocation needs to move up a level to Allocator::reallocate(Buffer&).
  • Similarly I think reshape may need moved to.
  • Revisit expression layer. As it's mocked-up I think we need to actually implement two expression layers (one for the buffer and one for TW proper). I think we can get by with just one if we drop the layer associated with the buffer.
  • add reshape(Buffer&) function to Shape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant