Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume loan list hasn't changed when unable to communicate with distributor #781

Open
leonardr opened this issue Nov 21, 2017 · 0 comments

Comments

@leonardr
Copy link
Contributor

If there's a problem connecting to a distributor to sync a patron's loans list, we assume that the patron has no loans from that distributor. Instead, we should assume that the patron's loans have not changed.

If the loans are still available and have been downloaded already, this should allow the patron to read their books. If it's not possible to get the book because of the same distributor problem that prevents loan sync, at least it doesn't make the situation worse by removing the loan.

This will make a situation worse in some cases, as loans can stick around after they should have expired, but distributor APIs generally aren't nonfunctional for that long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant