Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow load bib page placeholder #345

Open
EdwinGuzman opened this issue May 25, 2017 · 10 comments
Open

Slow load bib page placeholder #345

EdwinGuzman opened this issue May 25, 2017 · 10 comments

Comments

@EdwinGuzman
Copy link
Member

No description provided.

@ablwr
Copy link
Contributor

ablwr commented May 30, 2017

Do you have something in mind for this?

@EdwinGuzman
Copy link
Member Author

Something like this http://cloudcannon.com/deconstructions/2014/11/15/facebook-content-placeholder-deconstruction.html

Not important at the moment but it's just something I'd like to have in place eventually.

@mgiraldo
Copy link

that'd be cool... for the search results? for the item? both?

it could be like a class .placeholder added to the parent element that produces that sort of effect... ideally if i could make it without requiring extra elements... kind of like the spinners… you remove it and put the content when done... or maybe have empty elements that i can use...

for example, the search results would be:

  <li class="nypl-results-item placeholder">
    <h2></h2>
    <div class="nypl-results-item-description">
      <p>
        <span class="nypl-results-media"></span>
        <span class="nypl-results-place"></span>
        <span class="nypl-results-publisher"></span>
        <span class="nypl-results-date"></span>
        <span class="nypl-results-info"></span>
      </p>
      <p class="nypl-results-use"></p>
    </div>
  </li>

@EdwinGuzman
Copy link
Member Author

EdwinGuzman commented May 30, 2017

Perhaps. It's tricky because not all the data is there and some DOM elements are not rendered if there's no data. So you don't want to display a placeholder for something that is not there. So I'd imagine it to be more of a generic case for data that we will definitely display there. For example, in the above, nypl-results-info may not always appear so no point in making that a placeholder.

@mgiraldo
Copy link

ok so then i design a nypl-results-placeholder element that has some html and you just put that and replace (fade out/in) when you get results?

@EdwinGuzman
Copy link
Member Author

Perhaps. This ticket was more of a front-end investigation on my part instead implementation. Need to figure out how to do it properly and if it's needed at all.

@mgiraldo
Copy link

got it

@mgiraldo
Copy link

for future reference: http://emptystat.es/

@EdwinGuzman EdwinGuzman changed the title Slow load item page placeholder Slow load bib page placeholder Jun 29, 2017
@siberry
Copy link
Contributor

siberry commented Feb 27, 2020

Something like this http://cloudcannon.com/deconstructions/2014/11/15/facebook-content-placeholder-deconstruction.html

Not important at the moment but it's just something I'd like to have in place eventually.

@danamansana I think I remember you mentioning something like this. Would definitely be a ~ post-launch ~. But thought you'd like to see the reference.

@EdwinGuzman
Copy link
Member Author

I would love for this to actually get implemented now. As per a different comment, check "if it's needed at all".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants