Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove-desk-page? Because everything is broken #48

Open
j2l opened this issue Jan 15, 2025 · 6 comments
Open

How to remove-desk-page? Because everything is broken #48

j2l opened this issue Jan 15, 2025 · 6 comments

Comments

@j2l
Copy link

j2l commented Jan 15, 2025

bench --site <site-name> add-desk-page --app <app-name>
now my backend is broken:
image
On the server (VSCode dev containers), it's 304:

09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/frappe/css/fonts/inter/InterVariable.woff2 HTTP/1.1" 200 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/erpnext/images/erpnext-favicon.svg HTTP/1.1" 200 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/library_tut/dist/js/desk.bundle.KACLTQML.js.map HTTP/1.1" 304 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/frappe/dist/js/list.bundle.G3YA3BJI.js.map HTTP/1.1" 304 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/frappe/dist/js/form.bundle.I3D74H2C.js.map HTTP/1.1" 304 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/frappe/dist/js/controls.bundle.27PDBBGU.js.map HTTP/1.1" 304 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/frappe/dist/js/telemetry.bundle.ZJBT5ETW.js.map HTTP/1.1" 304 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/frappe/dist/js/report.bundle.XLU6EZIU.js.map HTTP/1.1" 304 -
09:29:27 web.1      | 172.26.0.1 - - [15/Jan/2025 09:29:27] "GET /assets/erpnext/dist/js/erpnext.bundle.JME2BL3X.js.map HTTP/1.1" 304 -
09:29:33 watch.1    | Watching for changes...

bench rm doppio didn't fix it

How to bench --site <site-name> remove-desk-page?
Is there a function?
Thank you

@j2l j2l changed the title how to remove-app, because everything is broken How to remove-desk-page? Because everything is broken Jan 15, 2025
@NagariaHussain
Copy link
Owner

Probably directly removing doppio made it worse. A rebuild should have fixed it.

@j2l
Copy link
Author

j2l commented Jan 15, 2025

yarn build is forbidden on frappe containers: https://github.com/frappe/frappe_docker/wiki/Frequently-Asked-Questions
prod or dev, it breaks everything.
I did bench --site ... reinstall, still didn't fix it totally (still no css and js, only web forms, I don't even speak about data, hopefully that's a test server).
Would you please implement a way to cleanly remove doppio?

@NagariaHussain
Copy link
Owner

bench remove-app is the right way to uninstall an app. In your PR description, you seem to have run rm.

@j2l
Copy link
Author

j2l commented Jan 16, 2025

These are the same:

bench remove-app --help
Usage: bench remove-app [OPTIONS] APP_NAME

  Completely remove app from bench and re-build assets if not installed on
  any site

Options:
  --no-backup  Do not backup app before removing
  --force      Force remove app
  --help       Show this message and exit.


(env) /workspace/development/frappe-bench:bench rm --help
Usage: bench rm [OPTIONS] APP_NAME

  Completely remove app from bench and re-build assets if not installed on
  any site

Options:
  --no-backup  Do not backup app before removing
  --force      Force remove app
  --help       Show this message and exit.
``

@NagariaHussain
Copy link
Owner

NagariaHussain commented Jan 16, 2025

Oh my bad, I just read the rm part 😅

In that case, doppio app itself doesn't hold anything other than the commands that setup SPAs or Pages. The app you configured them on (while running the command) has the generated code/boilerplate.

@NagariaHussain
Copy link
Owner

Try to run:

bench build --app <app-name>

App name is the app you setup the desk page in and see if it has any errors. That will be root cause most probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants