Skip to content
This repository has been archived by the owner on May 8, 2020. It is now read-only.

Still doesnt save colours? #42

Closed
FrezZyyyx opened this issue Apr 5, 2020 · 9 comments
Closed

Still doesnt save colours? #42

FrezZyyyx opened this issue Apr 5, 2020 · 9 comments

Comments

@FrezZyyyx
Copy link

what did u do exactly to try to fix it? cause i just recently updated to newest version of apg and advanced dupe 2 and its still has same issue. i paid someone to add a fix for it and it worked but i wanna use the most up to date versions of apg and advanced dupe 2 so. this is what the guy said when i asked what he did to fix it.

image

@thegrb93
Copy link

thegrb93 commented Apr 5, 2020

You can try deleting

APG._SetColor = APG._SetColor or ENT.SetColor
function ENT:SetColor( color, ... )
if not APG.cfg["ghostColorToggle"].value then return end
local color = color
local r, g, b, a
if type(color) == "number" then
color = Color(color, select(1, ...) or 255, select(2, ...) or 255, select(3, ...) or 255)
elseif type(color) == "table" and not IsColor(color) then
r = color.r or 255
g = color.g or 255
b = color.b or 255
a = color.a or 255
color = Color(r, g, b, a)
end
if not IsColor(color) then
ErrorNoHalt( "Invalid color passed to SetColor!\nThis error prevents stuff from turning purple/pink." )
else
APG._SetColor( self, color )
end
end
and
ent:SetColor( APG.cfg[ "ghostColor" ].value )
and
ent:SetColor( ent.APG_oldColor or Color( 255, 255, 255, 255) )

And see if it works after that.

@FrezZyyyx
Copy link
Author

will try it

@AvarianKnight
Copy link
Collaborator

AvarianKnight commented Apr 6, 2020

You should be able to turn ghostColorToggle ("Enable Color" under Ghosting) and it will prevent colors from changing. This was the fix that was made but it is not forced off by default.

@NanoAi
Copy link
Owner

NanoAi commented Apr 6, 2020

Please try out the settings with the latest version, and let me know if it's fixed. @FrezZyyyx
9029932#diff-80879291e1a242b387cfc0bf4700abc5L48

@thegrb93
Copy link

thegrb93 commented Apr 7, 2020

That was a bug for sure, but I don't think that's the problem. The problem is APG_oldColor is assigned before advdupe2 can assign a color, so after the APG_oldColor is reverted, the prop just loses its color.

@NanoAi
Copy link
Owner

NanoAi commented Apr 7, 2020

That was a bug for sure, but I don't think that's the problem. The problem is APG_oldColor is assigned before advdupe2 can assign a color, so after the APG_oldColor is reverted, the prop just loses its color.

Yeah I suggested just grabbing the colour data from duplicator.DoGeneric as I'm sure the correct colour will be in there. #44

This should then updated the stored information and restore the correct colours when unghosting.

@FrezZyyyx
Copy link
Author

ill dl the new version now

@FrezZyyyx
Copy link
Author

so you fixed this yourself in the newest version yes?

@NanoAi NanoAi closed this as completed May 2, 2020
@NanoAi
Copy link
Owner

NanoAi commented May 2, 2020

Assumed fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants