Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplace assignment doesn't work in this specific case #7283

Open
H-A-M-G-E-R opened this issue Dec 14, 2024 · 3 comments
Open

Inplace assignment doesn't work in this specific case #7283

H-A-M-G-E-R opened this issue Dec 14, 2024 · 3 comments

Comments

@H-A-M-G-E-R
Copy link

Even with the "Use inplace assignment operators" option enabled:
image

@astrelsky
Copy link
Contributor

astrelsky commented Dec 14, 2024

0.01% of the time it works everytime

There is an open pull request somewhere that improves it, however I found that it still didn't always work, usually with indirect reads/writes.

@msm-code
Copy link

I couldn't find a PR, but here is the issue with patch that you mentioned: #5601

Looks like the author has several more pending PRs that (hopefully) improve decompilation too:
https://github.com/NationalSecurityAgency/ghidra/pulls?q=author%3Alukeserne

@astrelsky
Copy link
Contributor

I couldn't find a PR, but here is the issue with patch that you mentioned: #5601

Looks like the author has several more pending PRs that (hopefully) improve decompilation too:
https://github.com/NationalSecurityAgency/ghidra/pulls?q=author%3Alukeserne

Ah yes that is what I was referring to ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants