Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to place plugin tests? #3

Open
agonper opened this issue Sep 16, 2020 · 4 comments
Open

Where to place plugin tests? #3

agonper opened this issue Sep 16, 2020 · 4 comments
Assignees

Comments

@agonper
Copy link
Contributor

agonper commented Sep 16, 2020

Hello,

First of all, thank you very much for the big effort you've invested on this. It looks awesome.

I've been checking the plugins repo and I can't see where all the tests have gone. I see a jest config file on the root folder but nothing else.

I would like to migrate three of our organization plugins to this new approach. We have a plethora of Jasmine plugins in our repos which are setup to run on TravisCI, we wouldn't like to loose that. Any migration tips?

Note: we haven't made it possible to run tests on the demo app after NS7 migration, but that's another issue ;)

Thanks in advance

@NathanWalker
Copy link
Contributor

Great question @agonper were working on the test runner - it also needed adjustments for es2017 targeting. Aiming at next week to complete its compliance and then we’ll add a migration to add it to all workspaces out there 👍

@agonper
Copy link
Contributor Author

agonper commented Sep 17, 2020

Thanks @NathanWalker for the quick response. I appreciate it.

If that's the case, we'll delay the migration to NS7 a little bit. It is good to know that you're working on the test runner. I was having the intuition that our problem with that was related to the new module system.

May I ask how can I be informed once the test runner is stable enough to migrate our plugins to NS7 and to the new workspace system?

Many thanks for your effort. NativeScript has been a game changer for us and we are happy to see how it progresses from being community driven.

@NathanWalker
Copy link
Contributor

You can monitor this issue here 👍 I’ll post back once we have the test runner going.

@agonper
Copy link
Contributor Author

agonper commented Sep 17, 2020

Awesome. Thanks!

@NathanWalker NathanWalker self-assigned this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants