Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug): SRT read fails if text starts with number #20

Open
7 of 10 tasks
hellocatfood opened this issue May 25, 2022 · 3 comments
Open
7 of 10 tasks

(Bug): SRT read fails if text starts with number #20

hellocatfood opened this issue May 25, 2022 · 3 comments
Assignees
Labels

Comments

@hellocatfood
Copy link
Contributor

hellocatfood commented May 25, 2022

Make sure to follow our issue report guidelines

  • I'm using the latest version of Natron (not required but recommended)
  • I've restarted Natron and the issue persists
  • I've run Natron via the command line and the issue persists
  • I've followed the contributing guidelines to the best of my understanding
  • My issue is not on the issue tracker or in a pull request already (go search for it and dig around a little bit!)
  • This bug is reproducible

Natron version

2.5 Snapshot

Operating system

Ubuntu 22.04

System specs

RAM: 64GB
CPU: 11th Gen Intel® Core™ i9-11900H @ 2.50GHz × 16
GPU: NVIDIA Corporation GA107M [GeForce RTX 3050 Ti Mobile] / NVIDIA GeForce RTX 3050 Ti Laptop GPU/PCIe/SSE2

Did you install Natron using the official installer?

  • Yes, I used the official installer
  • No, I installed from a binary archive
  • No, I compiled Natron from sources
  • No, I installed Natron via another method

Custom installation path

No response

What were you trying to do?

I am trying to read a subtitle (.srt) file into the Text node. The contents of the file are:

1
00:00:00,000 --> 00:00:01,500
First item in a list

2
00:00:01,600 --> 00:00:03,100
2. Second item

3
00:00:03,200 --> 00:00:04,700
Third item

example_subtitle.zip

What did you expect to happen? What happened instead?

The file can be read and played back, however the second subtitle doesn't display.

Peek 2022-05-25 19-20

I suspect this is because the second subtitle starts with a number

Step-by-step reproduction instructions

  1. Start Natron
  2. Add a Text node
  3. Load the above .srt file

Additional details

No response

@rodlie rodlie transferred this issue from NatronGitHub/Natron May 25, 2022
@rodlie rodlie self-assigned this May 25, 2022
@rodlie
Copy link
Collaborator

rodlie commented May 25, 2022

Will take a look tomorrow, don't think it's the number.

The SRT function probably contains some bugs, I did limited testing when I made it (a long time ago).

@hellocatfood
Copy link
Contributor Author

hellocatfood commented May 25, 2022

Thanks! btw I updated the report and file as there was a slight error with my srt file (problem still exists though)

@rodlie
Copy link
Collaborator

rodlie commented May 25, 2022

I can confirm the issue, I also noticed an issue with the test file (https://github.com/NatronGitHub/openfx-arena/blob/master/Text/sample.srt), it makes one empty keyframe.

Not in front of my dev machine, so can't do much today. Probably an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants