Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into children update-ref call is too permissive #55

Open
orao opened this issue Mar 23, 2016 · 2 comments
Open

Merge into children update-ref call is too permissive #55

orao opened this issue Mar 23, 2016 · 2 comments
Labels
Milestone

Comments

@orao
Copy link
Collaborator

orao commented Mar 23, 2016

Currently when children are direct ancestors of the new commit that is made we move their branches instead of making a new commit. This behavior should only occur if the branch is an immediate parent and not necessarily any ancestor of the given commit.

The permissive behavior can be useful so we should probably make this a configurable option.

@orao orao added the bug label Mar 23, 2016
@orao
Copy link
Collaborator Author

orao commented Mar 24, 2016

There are two situations that need to be considered.

  • An empty child stream that is one commit behind and has inherited this change (affected stream with empty diff).
  • A source stream that was merged into its parent (promoted from in the previous transaction) which will be a second parent of our parent commit.

These two situations are the only ones I can think of that mean that we can fast-forward the child branch to the parent branch. All other situations should probably be made into cherry-picks. However, I don't know if it is even possible for a different situation to arise at the moment so perhaps issuing a warning would suffice?

Either way this needs to be considered in conjunction with issue #54.

@ghost
Copy link

ghost commented Mar 29, 2016

This isn't urgent since it doesn't seem to affect the conversions I've tested with.

@orao orao added invalid and removed invalid labels Apr 6, 2016
@ghost ghost added this to the Future milestone Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant