Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.70.0 #121

Open
4 tasks
mooori opened this issue Nov 6, 2023 · 0 comments
Open
4 tasks

Update MSRV to 1.70.0 #121

mooori opened this issue Nov 6, 2023 · 0 comments

Comments

@mooori
Copy link
Contributor

mooori commented Nov 6, 2023

Currently we still need to support Rust 1.69.0 for some users of this library. Once they are fine with upgrading to 1.70.0, we should bump near-plugin’s MSRV.

Reason: Using near-workspaces with Rust 1.69.0 requires manually downgrading some dependencies, which is bad developer experience and requires maintenance. (See the conversation in #118).

Tasks:

  • Bump rust-version in ./Cargo.toml and channel in ./rust-toolchain
  • Build test contracts with the new MSRV: bump channel in ./near-plugins-derive/tests/contracts/**/rust-toolchain
  • Remove ./scripts/fix-dependencies.sh
    • Stop executing that script in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant