Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space turfs do not update their ambient light when a dynamically lit turf is created beside them. #2746

Open
4 of 5 tasks
MistakeNot4892 opened this issue Oct 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@MistakeNot4892
Copy link
Contributor

Description of issue

See title.

Difference between expected and actual behavior

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf, as otherwise you would have thousands of space turfs pointlessly creating corners etc. However as it stands, they should be updated when a dynamically lit turf is created beside them.

Steps to reproduce

  • Enable starlight.
  • Go to space.
  • Spawn a turf.
  • Put a non-fullbright light source on the turf or nearby.
  • Observe that the edges are dark as though bordering a fulldark turf.

Specific information for locating

I believe this was previously handled in simulated turf init, but not sure.

Length of time in which bug has been known to occur

Presumably since ambient lights were added..

Client version, Server revision & Game ID

Current dev.

Issue bingo

  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this
@out-of-phaze
Copy link
Member

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf

? this doesn't make sense to me, space turfs have ambient light unconditionally now. is this issue outdated or is the description just wrong? is it just the same as #2090?

@MistakeNot4892
Copy link
Contributor Author

Per Discord, space only generates corners when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants