Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodules #69

Open
Necktschnagge opened this issue Dec 14, 2023 · 4 comments
Open

Update submodules #69

Necktschnagge opened this issue Dec 14, 2023 · 4 comments
Assignees
Labels
important Resolve this with priority

Comments

@Necktschnagge
Copy link
Owner

Try to reverse #42!
maybe update spdlog or googletest.

Lisa needed #42 to compile.

@Necktschnagge Necktschnagge added this to the 1.x Enhancements milestone Dec 14, 2023
@Necktschnagge Necktschnagge self-assigned this Dec 14, 2023
@Necktschnagge
Copy link
Owner Author

I now suspect the tobor_svg header to produce this warning. which is treated as an error.

One should check if when the error started. Was it when merging tobor_svg?

@Necktschnagge
Copy link
Owner Author

Do a binary search on Lisa to find the first commit on master causing compiler Werror warnings...

@Necktschnagge Necktschnagge linked a pull request Dec 16, 2023 that will close this issue
@Necktschnagge Necktschnagge removed a link to a pull request Dec 16, 2023
@Necktschnagge
Copy link
Owner Author

googletest has been updated here: #118

@Necktschnagge Necktschnagge added the important Resolve this with priority label May 7, 2024
@Necktschnagge
Copy link
Owner Author

it is spdlog. updated in #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Resolve this with priority
Projects
None yet
Development

No branches or pull requests

1 participant