Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate reading from xls #99

Open
NeilMacMullen opened this issue Jan 17, 2025 · 4 comments
Open

Investigate reading from xls #99

NeilMacMullen opened this issue Jan 17, 2025 · 4 comments

Comments

@NeilMacMullen
Copy link
Owner

Perhaps we could read from openxml excel files rather than forcing a conversion to CSV?

@ADefWebserver
Copy link
Contributor

What is the issue? If its Excel files I am having no issues with ExcelDataReader.DataSet

@NeilMacMullen
Copy link
Owner Author

thanks - that's a good suggestion. No technical issue; just that it hasn't been my priority to implement a suitable ITableLoader since I tend to work with csv/parquet/json. Plus there are lots of policy decisions to make around excel since you have multiple sheets. formatting, formulae etc so for a complicated spreadsheet you can't just say "read the data in the file"

@ADefWebserver
Copy link
Contributor

for a complicated spreadsheet you can't just say "read the data in the file"

Uhhh that's what I'm doing 😉🙏🏽🤣

@ADefWebserver
Copy link
Contributor

Tha advantage of using Excel at all is that it will provide column headers and "some" field types (Text, DateTime, Integer... ok basically that's it).

Otherwise, the only advantage is that: the data is already in excel format so why make them go any extra steps 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants