You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
julia> R,(x,y) = ZZ[:x,:y]
(Multivariate polynomial ring in 2 variables over integers, AbstractAlgebra.Generic.MPoly{BigInt}[x, y])
julia> f = AbstractAlgebra.MPolyFactor.mfactor_char_zero((2*x+x)^2)
9 * x^2
Looking at the code, I think what effectively happens is that f.unit is set to the content of the polynomial. But really that should also be factorized.
So in this case I'd expect an error to be thrown because we don't implement factor for BigInt.
One can now quibble whether this is a bug, after all AbstractAlgebra.MPolyFactor.mfactor_char_zero is not factor and could just declare that it doesn't handle factorization in the coefficient ring. In that interpretation, it simply alllows itself to abuse the unit field of type Fac to store a non-unit.
The text was updated successfully, but these errors were encountered:
Looking at the code, I think what effectively happens is that
f.unit
is set to the content of the polynomial. But really that should also be factorized.So in this case I'd expect an error to be thrown because we don't implement
factor
forBigInt
.One can now quibble whether this is a bug, after all
AbstractAlgebra.MPolyFactor.mfactor_char_zero
is notfactor
and could just declare that it doesn't handle factorization in the coefficient ring. In that interpretation, it simply alllows itself to abuse theunit
field of typeFac
to store a non-unit.The text was updated successfully, but these errors were encountered: