Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybindings for Enter and Tab don't fire #118

Open
andrechen77 opened this issue Oct 30, 2023 · 3 comments
Open

Keybindings for Enter and Tab don't fire #118

andrechen77 opened this issue Oct 30, 2023 · 3 comments
Labels
bug Something isn't working Top priority

Comments

@andrechen77
Copy link
Collaborator

Following 7f756de, it became possible for a client to directly add keybindings to the underlying CodeMirror instance. These bindings don't work for the 'Enter' and 'Tab' keys (as in, the handlers never fire).
@andrechen77 andrechen77 added the bug Something isn't working label Oct 30, 2023
@andrechen77
Copy link
Collaborator Author

I think it might have to do with this code adding competing keybindings with higher precedence. I think those handlers should return false if they don't/can't do anything, so that further handlers are tried.

@CIVITAS-John
Copy link
Contributor

Fixed with the latest commit.

@andrechen77
Copy link
Collaborator Author

See #119 (comment)

@andrechen77 andrechen77 reopened this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Top priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CIVITAS-John @andrechen77