Queue occupancy histogram #912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the semantics of num_buckets() to match the num_buckets constructor argument. Setting num_buckets assumed the user did not include the +1 bucket for above_range; getting num_buckets() did include the above_range bucket.
shinae-woo
reviewed
May 15, 2019
protobuf/module_msg.proto
Outdated
| @@ -243,22 +243,11 @@ message MeasureCommandGetSummaryArg { | |||
| * may not be a multiple of the resolution. | |||
| */ | |||
| message MeasureCommandGetSummaryResponse { | |||
There was a problem hiding this comment.
Could we avoid/minimize changing the protobuf message field names? There are many external project/repo using this, it's all broken. At least two of my project is not compatible with these changes.
Histogram functionality currently used in the Measure module will soon be used in other modules. This commit moves some helper functions and protobufs so they can be shared.
dtnaylor
force-pushed
the
queue-occupancy-ewma
branch
from
5a4f954 to
defafa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a histogram to the queue module which can be enabled to track statistics about queue occupancy.