Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a closeStream to the Read and Write methods #32

Open
mburbea opened this issue Feb 13, 2024 · 0 comments
Open

Consider adding a closeStream to the Read and Write methods #32

mburbea opened this issue Feb 13, 2024 · 0 comments

Comments

@mburbea
Copy link

mburbea commented Feb 13, 2024

Currently, SqlServerByteReader.Read(Stream)/SqlServerByteWriter.Write(Geometry, Stream) will close the underlying stream. It would be nice to have an option to reuse the stream.
I propose adding a leaveOpen= false parameter to each of these methods, and we can just manually turn it true to leave the passed in stream open.
I currently have a need to marshall data back and forth between SqlGeography and NTS land and it would be nice to not have to write a crappy dummy StreamWrapper just to avoid this disposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant