Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 2.0.0.1 version of Karyon has a bug that causes a stack dump error on shutdown. FIX AVAILABLE #229

Open
dan8080 opened this issue Jun 5, 2015 · 1 comment

Comments

@dan8080
Copy link

dan8080 commented Jun 5, 2015

I have a fix for it, just needs to be pulled into the main code for 2.0.0.1.
The bug is in
server/KaryonServer.java line 217.

old code:
Closeables.closeQuietly(lifecycleManager);

new code:
Closeables.close(lifecycleManager);

Explanation of the fix:
The version of Google Commons Guava that is linked with this version of Karyon does not have the closeQuietly method. It was added in later versions. However, the argument in teh original code does not match the parameters for closeQuietly anyway. I modified to use close, which expects a as a param -- LifecycleManager does implement closeable.

II coded this fix on the branch named "fixed" that I forked on my account. However, I do not seem to possess sufficient permissions to commit it to master so as to do a pull request.

@dan8080 dan8080 changed the title The 2.0.0.1 version of Karyon has a bug that causes a stack dump error on shutdown. The 2.0.0.1 version of Karyon has a bug that causes a stack dump error on shutdown. FIX AVAILABLE Jun 5, 2015
@NiteshKant
Copy link
Contributor

@dan8080 the change makes sense to me.

I do not seem to possess sufficient permissions to commit it to master so as to do a pull request.

Are you saying you do not have sufficient permissions to commit to master branch in your fork? Sounds strange, anyways, you can send a pull request from any branch in your fork to any branch in the Netflix/karyon repo if it is mergeable. More info on how to make pull requests is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants