You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a fix for it, just needs to be pulled into the main code for 2.0.0.1.
The bug is in
server/KaryonServer.java line 217.
old code:
Closeables.closeQuietly(lifecycleManager);
new code:
Closeables.close(lifecycleManager);
Explanation of the fix:
The version of Google Commons Guava that is linked with this version of Karyon does not have the closeQuietly method. It was added in later versions. However, the argument in teh original code does not match the parameters for closeQuietly anyway. I modified to use close, which expects a as a param -- LifecycleManager does implement closeable.
II coded this fix on the branch named "fixed" that I forked on my account. However, I do not seem to possess sufficient permissions to commit it to master so as to do a pull request.
The text was updated successfully, but these errors were encountered:
dan8080
changed the title
The 2.0.0.1 version of Karyon has a bug that causes a stack dump error on shutdown.
The 2.0.0.1 version of Karyon has a bug that causes a stack dump error on shutdown. FIX AVAILABLE
Jun 5, 2015
I do not seem to possess sufficient permissions to commit it to master so as to do a pull request.
Are you saying you do not have sufficient permissions to commit to master branch in your fork? Sounds strange, anyways, you can send a pull request from any branch in your fork to any branch in the Netflix/karyon repo if it is mergeable. More info on how to make pull requests is here
I have a fix for it, just needs to be pulled into the main code for 2.0.0.1.
The bug is in
server/KaryonServer.java line 217.
old code:
Closeables.closeQuietly(lifecycleManager);
new code:
Closeables.close(lifecycleManager);
Explanation of the fix:
The version of Google Commons Guava that is linked with this version of Karyon does not have the closeQuietly method. It was added in later versions. However, the argument in teh original code does not match the parameters for closeQuietly anyway. I modified to use close, which expects a as a param -- LifecycleManager does implement closeable.
II coded this fix on the branch named "fixed" that I forked on my account. However, I do not seem to possess sufficient permissions to commit it to master so as to do a pull request.
The text was updated successfully, but these errors were encountered: