Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncPostgresDB initialization retry logic #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AsyncPostgresDB initialization retry logic #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions services/migration_service/data/postgres_async_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,18 @@ def __init__(self):
AsyncPostgresDB.__instance = self

async def _init(self, db_conf: DBConfiguration):
# todo make poolsize min and max configurable as well as timeout
# todo add retry and better error message
retries = 3
for i in range(retries):
# todo make poolsize min and max configurable
max_attempts = 3
while max_attempts > 0:
try:
self.pool = await aiopg.create_pool(db_conf.get_dsn(), timeout=db_conf.timeout)
break
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it not have been sufficient to just add the break to the original code?

except Exception as e:
print("printing connection exception: " + str(e))
if retries - i < 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is never actually hit as range excludes the end, but can be fixed with a slight tweak f.ex.

if retries-(i+1) < 1:


max_attempts -= 1
if max_attempts == 0:
raise e

time.sleep(1)
continue