fix: conda/pypi usage of _user_defined_attributes #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romain-intel
reviewed
Dec 9, 2024
| **self._user_defined_attributes, | ||
| **conda_base._user_defined_attributes, | ||
| } | ||
| self._user_defined_attributes = self._user_defined_attributes.union( |
There was a problem hiding this comment.
I don't have an issue with this but we are overloading the meaning of _user_defined_attributes here since it is now a value across decorators. We don't currently use it but since you use it for a specfiic purpose, I would create a different name for it.
romain-intel
deleted the
fix/user-defined-attributes-fix-after-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base Decorator class now exposes
_user_defined_attributesas a set. This differs in how it is used in conda/pypi decorators, and for the current pypi implementation, using@pypi_baseleads to the set being used in dict splatting, resulting in an error.Streamlining the usage in this PR to be in line with what the base class provides.
TODO: