Fix issue where run_command blocks when it shouldn't #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where we need to read from a file (for the result of run_command), the current code used to make it sequential (so the timeout was actually never triggered). This started causing problems on MacOS when writing large amounts of data (8KB FIFO)
madhur-ob
reviewed
Dec 9, 2024
metaflow/runner/metaflow_runner.py
Outdated
| @@ -326,6 +326,7 @@ def run(self, **kwargs) -> ExecutingRun: | |||
| show_output=self.show_output, | |||
| ) | |||
| command_obj = self.spm.get(pid) | |||
| command_obj.sync_wait() | |||
|
|
|||
| return self.__get_executing_run(attribute_file_fd, command_obj) | |||
There was a problem hiding this comment.
I guess command_obj.sync_wait() for Runner should happen inside self.__get_executing_run since we wanna do it after content = handle_timeout(...)
madhur-ob
reviewed
Dec 9, 2024
metaflow/runner/metaflow_runner.py
Outdated
| @@ -357,6 +358,7 @@ def resume(self, **kwargs): | |||
| show_output=self.show_output, | |||
| ) | |||
| command_obj = self.spm.get(pid) | |||
| command_obj.sync_wait() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where we need to read from a file (for the result of run_command), the current code used to make it sequential (so the timeout was actually never triggered).
This started causing problems on MacOS when writing large amounts of data (8KB FIFO)