From b6576fdccfa5befb3e3ae5097ae99385e18f3caa Mon Sep 17 00:00:00 2001 From: brharrington Date: Fri, 6 Jan 2023 07:54:27 -0600 Subject: [PATCH] do not shade slf4j in spark jar (#1023) This makes it easier to have consistent logging and slf4j typically isn't an issue with conflicting versions in the spark distribution. --- spectator-ext-spark/build.gradle | 2 -- 1 file changed, 2 deletions(-) diff --git a/spectator-ext-spark/build.gradle b/spectator-ext-spark/build.gradle index 887488d84..df13f958f 100644 --- a/spectator-ext-spark/build.gradle +++ b/spectator-ext-spark/build.gradle @@ -40,7 +40,6 @@ shadowJar { include project(':spectator-ext-jvm') include project(':spectator-reg-sidecar') include dependency('com.typesafe:config') - include dependency('org.slf4j:slf4j-api') } minimize() @@ -53,7 +52,6 @@ shadowJar { relocate 'com.netflix.spectator.ipc', 'spectator-ext-spark.ipc' relocate 'com.netflix.spectator.jvm', 'spectator-ext-spark.jvm' relocate 'com.netflix.spectator.sidecar', 'spectator-ext-spark.sidecar' - relocate 'org.slf4j', 'spectator-ext-spark.slf4j' relocate 'com.typesafe', 'spectator-ext-spark.com.typesafe' }