Migration tool blindly removes external user domain

[DavidePrincipi]

⚠ I found a failure scenario:

• Start migration of NS7-A to ldap domain ns7.test
• Start migration of NS7-B to ldap domain ns7.test

In NS8 the external domain created by NS7-A is replaced.

• I'd expect an error message if the external domain is already bound to a working NS7 node, or to an external LDAP service. Before removing any existing domain, we must check if the domain is in use or not.
• As alternative, if an automatic check is too difficult, abort the join step completely and ask the user to manually remove the domain on NS8.

NOTE: I run the test with an old RPM nethserver-ns8-migration-1.0.18-1.9.pr94.g965a884.ns7.x86_64

Originally posted by @DavidePrincipi in #7103

Discussion: https://mattermost.nethesis.it/nethesis/pl/84unkibbo3rg7cbcrs454f5ksc

[nethbot]

in 7.9.2009/testing:

• nethserver-ns8-migration-1.0.18-1.29.gfafd227.ns7.x86_64.rpm x86_64

[stephdl]

QA
For this test you need two NS7 (NS7-1 and NS7-2) and one NS8

The migration rpm to test :

yum install http://packages.nethserver.org/nethserver/7.9.2009/testing/x86_64/Packages/nethserver-ns8-migration-1.0.18-1.32.g5c37353.ns7.x86_64.rpm

case 1 openldap

• Install NS7-1 with an account provider (openldap)
• Install nethserver-ns8-migration from testing
• Join the NS8 node with ldap.domain.com
• Now the test continue another NS7-2
• Install NS7-2 with an account provider (openldap)
• Install nethserver-ns8-migration from testing
• join the NS8 node with ldap.domain.com

The validator must prevent to join the node with NS7-2 and the domain ldap.domain.com

case 2 SAMBA AD

• Install NS7-1 with an account provider (samba ad), set ad.domain.com as the DN of the LDAP
• Install nethserver-ns8-migration from testing
• Join the NS8 node
• Now the test continue with another NS7-2
• Install NS7-2 with an account provider (samba ad), set ad.domain.com as the DN of the LDAP
• Install nethserver-ns8-migration from testing
• join the NS8 node

The validator must prevent to join the node with NS7-2 and the domain ad.domain.com

[nrauso]

test case 1: VERIFIED
test case 2: NOT VERIFIED