Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement erc20 streaming #237

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

feat: implement erc20 streaming #237

wants to merge 10 commits into from

Conversation

Mystic-Nayy
Copy link

@Mystic-Nayy Mystic-Nayy commented Jul 22, 2024 •
edited by julio4
Loading

Issue: Close #196

@Mystic-Nayy

This comment was marked as off-topic.

Sign in to view
@Mystic-Nayy
Copy link
Author

@julio4 can you take a look at this?

@Mystic-Nayy Mystic-Nayy marked this pull request as ready for review August 13, 2024 06:08
julio4
julio4 requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some improvements.
Todo:

  • write the chapter page in src
  • update to last edition 2024_07

Sorry for the late review, @Gift-Naomi do you still want to work on it or I'll finish it

listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
@Mystic-Nayy
Copy link
Author

Looks good, but some improvements. Todo:

  • write the chapter page in src
  • update to last edition 2024_07

Sorry for the late review, @Gift-Naomi do you still want to work on it or I'll finish it

@julio4 Yes sir
I will continue working on it and make the necessary corrections

@julio4
Copy link
Contributor

julio4 commented Oct 3, 2024

Looks good, but some improvements. Todo:

  • write the chapter page in src
  • update to last edition 2024_07

Sorry for the late review, @Gift-Naomi do you still want to work on it or I'll finish it

@julio4 Yes sir I will continue working on it and make the necessary corrections

Perfect, thank you a lot!

@Mystic-Nayy
Copy link
Author

@julio4 I have made the changes, can you review please .

julio4
julio4 requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some changes to make. Please take a few minutes to read and review all contribution guidelines! Thank you

listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
src/applications/erc20.md Outdated Show resolved Hide resolved
src/applications/erc20.md Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Show resolved Hide resolved
@Mystic-Nayy
Copy link
Author

@julio4 I have not gotten any review from you yet.

julio4
julio4 requested changes Oct 24, 2024
View reviewed changes
src/applications/token_streaming.md Outdated Show resolved Hide resolved
src/applications/erc20.md Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
listings/applications/erc20/src/erc20_streaming.cairo Outdated Show resolved Hide resolved
@Mystic-Nayy
Copy link
Author

@julio4 Hi ser
I have made the reviewed changes.

julio4
julio4 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@julio4 julio4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'll make the last minor changes myself before merging.

@Mystic-Nayy
Copy link
Author

LGTM I'll make the last minor changes myself before merging.

@julio4 Alright sir, thanks

@julio4 julio4 changed the base branch from main to dev November 20, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio4 julio4 julio4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: ERC20 Token Streaming
2 participants
@Mystic-Nayy @julio4