Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid default parameter provided for node setup #12

Open
raxhvl opened this issue Jul 29, 2024 · 0 comments · May be fixed by #13
Open

Invalid default parameter provided for node setup #12

raxhvl opened this issue Jul 29, 2024 · 0 comments · May be fixed by #13

Comments

@raxhvl
Copy link

raxhvl commented Jul 29, 2024

The JSON value provided for the default parameter is invalid.

gas-benchmarks/setup_node.py

Lines 44 to 45 in 744c638

default='{"nethermind": "default", "besu": "default", "geth": "default", "reth": "default"}, '
'"erigon": "default"}')

This causes the script to break when decoding the JSON.

Using provided image: default for geth
image Bulk: {"nethermind": "default", "besu": "default", "geth": "default", "reth": "default"}, "erigon": "default"}
Traceback (most recent call last):
  File "gas-benchmarks/setup_node.py", line 86, in <module>
    main()
  File "gas-benchmarks/setup_node.py", line 67, in main
    images_json = json.loads(images_bulk)
                  ^^^^^^^^^^^^^^^^^^^^^^^
  File <path>3.11.4/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
raxhvl added a commit to raxhvl/gas-benchmarks that referenced this issue Jul 29, 2024
@raxhvl
🐞 fix: NethermindEth#12
3c27483
@raxhvl raxhvl linked a pull request Jul 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐞 fix: Invalid default parameter provided for node setup raxhvl/gas-benchmarks
1 participant
@raxhvl