Ensure p2p protocol matches new Starknet spec #2291
Draft
+150
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
+ Coverage 75.32% 75.43% +0.11%
==========================================
Files 107 107
Lines 11406 11406
==========================================
+ Hits 8591 8604 +13
+ Misses 2158 2149 -9
+ Partials 657 653 -4 ☔ View full report in Codecov by Sentry. |
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
4 times, most recently
from
ee1b5ee to
ff56ae3
Compare
kirugan
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
ff56ae3 to
586824e
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
586824e to
ff3cdc2
Compare
wojciechos
changed the title
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
3 times, most recently
from
426e56d to
df1ed30
Compare
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
7 times, most recently
from
629f346 to
cf17942
Compare
Use dht.ProtocolExtension to set chainID in protocol ID format for DHT. Add test to verify protocol ID format for different networks: - /starknet/SN_SEPOLIA/kad/1.0.0 for Sepolia - /starknet/SN_MAIN/kad/1.0.0 for Mainnet The change ensures that DHT protocol follow latest Starknet specification.
wojciechos
force-pushed
the
wojciechos/p2p-protocol-name
branch
from
cf17942 to
02d963d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/starknet/<chain_id>/sync/...Protocol Path Changes:
Before:
/starknet/headers/0.1.0-rc.0/starknet/events/0.1.0-rc.0After:
/starknet/SN_MAIN/sync/headers/0.1.0-rc.0/starknet/SN_SEPOLIA/sync/events/0.1.0-rc.0