Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like we had the same idea #1

Closed
ZeusJunior opened this issue Oct 14, 2019 · 2 comments
Closed

Looks like we had the same idea #1

ZeusJunior opened this issue Oct 14, 2019 · 2 comments

Comments

@ZeusJunior
Copy link
Contributor

Hi,

I noticed this repo was last updated 3/4th of a year ago and decided to fork it and edit myself.
You must've noticed or its just a nice timing because today you added spells being marked on compare links which i just finished locally.

Thought it might be an idea to edit this together instead if you're interested. My steam link:
https://steamcommunity.com/profiles/76561198144346135

@ZeusJunior
Copy link
Contributor Author

Just heard from glen that you're Jack from the bptf discord

@NetroScript
Copy link
Owner

You are correct, I read your message in discord, first I wanted to tell you how you would do it until I realised you forked my userscript and talked about it so I added it myself. And forking is nothing wrong, although I want to mention I more or less keep all my userscripts up to date, only that this script didn't need any updates (no new skins, no feature requests in the issues). So you can go ahead and add features if you want, but at least if you want to keep it up with the main branch (should I do changes) it would be less work for you to PR instead of updating your fork everytime. (But the license is Apache License 2.0 so you can do what you think is better)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants