Merge pull request #277 from plural/card-and-printing-resource-specs

Add specs for card and printing resources.

Author: plural

app/models/card.rb

@@ -1,47 +1,72 @@
 # frozen_string_literal: true
+
 class Card < ApplicationRecord
   self.table_name = 'unified_cards'
   include CardAbilities
 
   self.primary_key = :id
 
+  def latest_printing_id
+    printing_ids[0]
+  rescue StandardError
+    nil
+  end
+
+  def restrictions
+    {
+      banned: restrictions_banned,
+      global_penalty: restrictions_global_penalty,
+      points: packed_restriction_to_map(restrictions_points),
+      restricted: restrictions_restricted,
+      universal_faction_cost: packed_restriction_to_map(restrictions_universal_faction_cost)
+    }
+  end
+
   belongs_to :card_type
   belongs_to :faction
   belongs_to :side
 
-  scope :by_card_cycle, ->(card_cycle_id) {
-    where(id: Printing.select(:card_id).where(card_cycle_id: card_cycle_id))
+  scope :by_card_cycle, lambda { |card_cycle_id|
+    where(id: Printing.select(:card_id).where(card_cycle_id:))
   }
-  scope :by_card_set, ->(card_set_id) {
-    where(id: Printing.select(:card_id).where(card_set_id: card_set_id))
+  scope :by_card_set, lambda { |card_set_id|
+    where(id: Printing.select(:card_id).where(card_set_id:))
   }
 
   has_many :card_card_subtypes,
-           primary_key: :id,
-           foreign_key: :card_id
+           primary_key: :id
 
   has_many :card_subtypes, through: :card_card_subtypes
 
   has_many :raw_printings,
            class_name: 'RawPrinting',
-           primary_key: :id,
-           foreign_key: :card_id
+           primary_key: :id
 
   has_many :printings,
-           primary_key: :id,
-           foreign_key: :card_id
+           primary_key: :id
 
   has_many :card_cycles, through: :printings
+  has_many :card_sets, through: :printings
 
   has_many :rulings,
-           primary_key: :id,
-           foreign_key: :card_id
+           primary_key: :id
 
   # Private decks
-  has_many :deck_cards, primary_key: :id, foreign_key: :card_id
-  has_many :decks, through: :deck_cards, primary_key: :id, foreign_key: :card_id
+  has_many :deck_cards, primary_key: :id
+  has_many :decks, through: :deck_cards, primary_key: :id
 
   # Public decklists
-  has_many :decklist_cards, primary_key: :id, foreign_key: :card_id
-  has_many :decklists, through: :decklist_cards, primary_key: :id, foreign_key: :card_id
+  has_many :decklist_cards, primary_key: :id
+  has_many :decklists, through: :decklist_cards, primary_key: :id
+
+  private
+
+  def packed_restriction_to_map(packed)
+    m = {}
+    packed.each do |p|
+      x = p.split('=')
+      m[x[0]] = x[1].to_i
+    end
+    m
+  end
 end

app/models/concerns/card_abilities.rb

@@ -1,22 +1,25 @@
+# frozen_string_literal: true
+
+# Module included by Card and Printing to expose common card ability attributes.
 module CardAbilities
-    extend ActiveSupport::Concern
+  extend ActiveSupport::Concern
 
-    included do
-        def card_abilities
-            {
-            additional_cost: self.additional_cost,
-            advanceable: self.advanceable,
-            gains_subroutines: self.gains_subroutines,
-            interrupt: self.interrupt,
-            link_provided: self.link_provided,
-            mu_provided: self.mu_provided,
-            num_printed_subroutines: self.num_printed_subroutines,
-            on_encounter_effect: self.on_encounter_effect,
-            performs_trace: self.performs_trace,
-            recurring_credits_provided: self.recurring_credits_provided,
-            rez_effect: self.rez_effect,
-            trash_ability: self.trash_ability,
-            }
-        end
+  included do
+    def card_abilities
+      {
+        additional_cost:,
+        advanceable:,
+        gains_subroutines:,
+        interrupt:,
+        link_provided:,
+        mu_provided:,
+        num_printed_subroutines:,
+        on_encounter_effect:,
+        performs_trace:,
+        recurring_credits_provided:,
+        rez_effect:,
+        trash_ability:
+      }
     end
-end
+  end
+end

app/models/printing.rb

@@ -5,19 +5,18 @@ class Printing < ApplicationRecord
 
   self.primary_key = :id
 
-  belongs_to :side
   belongs_to :card
   belongs_to :card_set
 
-  has_one :faction, through: :card
-  has_one :card_cycle, through: :card_set
-  has_one :card_type, through: :card
+  belongs_to :faction
+  belongs_to :card_cycle
+  belongs_to :card_type
 
   has_many :printing_card_subtypes,
            primary_key: :id
   has_many :card_subtypes, through: :printing_card_subtypes
 
-  has_one :side, through: :card
+  belongs_to :side
   has_many :illustrator_printings,
            primary_key: :id
   has_many :illustrators, through: :illustrator_printings
@@ -29,4 +28,45 @@ class Printing < ApplicationRecord
            primary_key: :card_id,
            foreign_key: :card_id
   has_many :card_pools, through: :card_pool_cards
+
+  def images
+    { 'nrdb_classic' => nrdb_classic_images }
+  end
+
+  def latest_printing_id
+    printing_ids[0]
+  rescue StandardError
+    nil
+  end
+
+  def restrictions
+    {
+      banned: restrictions_banned,
+      global_penalty: restrictions_global_penalty,
+      points: packed_restriction_to_map(restrictions_points),
+      restricted: restrictions_restricted,
+      universal_faction_cost: packed_restriction_to_map(restrictions_universal_faction_cost)
+    }
+  end
+
+  private
+
+  def nrdb_classic_images
+    url_prefix = Rails.configuration.x.printing_images.nrdb_classic_prefix
+    {
+      'tiny' => format('%s/tiny/%s.jpg', url_prefix, id),
+      'small' => format('%s/small/%s.jpg', url_prefix, id),
+      'medium' => format('%s/medium/%s.jpg', url_prefix, id),
+      'large' => format('%s/large/%s.jpg', url_prefix, id)
+    }
+  end
+
+  def packed_restriction_to_map(packed)
+    m = {}
+    packed.each do |p|
+      x = p.split('=')
+      m[x[0]] = x[1].to_i
+    end
+    m
+  end
 end

app/resources/card_resource.rb

@@ -4,20 +4,23 @@
 class CardResource < ApplicationResource
   primary_endpoint '/cards', %i[index show]
 
+  self.default_page_size = 1000
+
   attribute :id, :string
   attribute :stripped_title, :string
   attribute :title, :string
   attribute :card_type_id, :string
   attribute :side_id, :string
   attribute :faction_id, :string
+  # TODO(plural): Move cost and agenda requirements into model.
+  attribute :cost, :string do
+    @object.cost == -1 ? 'X' : @object.cost
+  end
   attribute :advancement_requirement, :string do
     @object.advancement_requirement == -1 ? 'X' : @object.advancement_requirement
   end
   attribute :agenda_points, :integer
   attribute :base_link, :integer
-  attribute :cost, :string do
-    @object.cost == -1 ? 'X' : @object.cost
-  end
   attribute :deck_limit, :integer
   attribute :in_restriction, :boolean
   attribute :influence_cost, :integer
@@ -43,34 +46,15 @@ class CardResource < ApplicationResource
   attribute :card_cycle_ids, :array_of_strings
   attribute :card_set_ids, :array_of_strings
   attribute :designed_by, :string
-  attribute :printings_released_by, :string
+  attribute :printings_released_by, :array_of_strings
   attribute :pronouns, :string
   attribute :pronunciation_approximation, :string
   attribute :pronunciation_ipa, :string
 
   # Synthesized attributes
   attribute :card_abilities, :hash
-  def packed_restriction_to_map(packed)
-    m = {}
-    packed.each do |p|
-      x = p.split('=')
-      m[x[0]] = x[1].to_i
-    end
-    m
-  end
-
-  attribute :restrictions, :hash do
-    {
-      banned: @object.restrictions_banned,
-      global_penalty: @object.restrictions_global_penalty,
-      points: packed_restriction_to_map(@object.restrictions_points),
-      restricted: @object.restrictions_restricted,
-      universal_faction_cost: packed_restriction_to_map(@object.restrictions_universal_faction_cost)
-    }
-  end
-  attribute :latest_printing_id, :string do
-    @object.printing_ids[0]
-  end
+  attribute :restrictions, :hash
+  attribute :latest_printing_id, :string
 
   filter :card_cycle_id, :string do
     eq do |scope, value|
@@ -98,35 +82,35 @@ def packed_restriction_to_map(packed)
     end
   end
 
-  has_many :card_cycles do
+  many_to_many :card_cycles do
     link do |c|
-      '%s?filter[id]=%s' % [Rails.application.routes.url_helpers.card_cycles_url, c.card_cycle_ids.join(',')]
+      format('%s?filter[id]=%s', Rails.application.routes.url_helpers.card_cycles_url, c.card_cycle_ids.join(','))
     end
   end
-  has_many :card_sets do
+  many_to_many :card_sets do
     link do |c|
-      '%s?filter[id]=%s' % [Rails.application.routes.url_helpers.card_sets_url, c.card_set_ids.join(',')]
+      format('%s?filter[id]=%s', Rails.application.routes.url_helpers.card_sets_url, c.card_set_ids.join(','))
     end
   end
   many_to_many :card_subtypes do
     link do |c|
       card_subtype_ids = c.card_subtype_ids.empty? ? 'none' : c.card_subtype_ids.join(',')
-      '%s?filter[id]=%s' % [Rails.application.routes.url_helpers.card_subtypes_url, card_subtype_ids]
+      format('%s?filter[id]=%s', Rails.application.routes.url_helpers.card_subtypes_url, card_subtype_ids)
     end
   end
   belongs_to :card_type
   belongs_to :faction
   has_many :printings do
     link do |c|
-      '%s?filter[card_id]=%s' % [Rails.application.routes.url_helpers.printings_url, c.id]
+      format('%s?filter[card_id]=%s', Rails.application.routes.url_helpers.printings_url, c.id)
     end
   end
   has_many :rulings
   belongs_to :side
 
   many_to_many :decklists do
     link do |c|
-      '%s?filter[card_id]=%s' % [Rails.application.routes.url_helpers.decklists_url, c.id]
+      format('%s?filter[card_id]=%s', Rails.application.routes.url_helpers.decklists_url, c.id)
     end
   end
 end